Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suffix and suffixes for no suffix #209

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Feb 8, 2022

Fixes #120

@jayqi jayqi requested a review from pjbull February 8, 2022 16:07
@jayqi jayqi changed the title Fix suffix and suffixes for no suffix. Fixes #120 Fix suffix and suffixes for no suffix Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

@jayqi jayqi force-pushed the 208-fix-suffix-suffixes branch from 65fba79 to 339f1af Compare February 8, 2022 17:20
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #209 (339f1af) into master (2084e20) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #209   +/-   ##
======================================
  Coverage    94.7%   94.7%           
======================================
  Files          21      21           
  Lines        1247    1248    +1     
======================================
+ Hits         1182    1183    +1     
  Misses         65      65           
Impacted Files Coverage Δ
cloudpathlib/cloudpath.py 93.1% <100.0%> (+<0.1%) ⬆️

@jayqi jayqi merged commit 4ddcf84 into master Feb 8, 2022
@jayqi jayqi deleted the 208-fix-suffix-suffixes branch February 8, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling .suffix on a dir raises IndexError
2 participants