-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _s3_file_query to check if an object exists explicitly. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
======================================
Coverage 94.1% 94.1%
======================================
Files 21 21
Lines 1183 1189 +6
======================================
+ Hits 1114 1120 +6
Misses 69 69
|
jayqi
requested changes
Sep 17, 2021
Thanks @jayqi should be good now! |
jayqi
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our current setup, the
_is_file_or_dir
check relies on_s3_file_query
, which requires list permissions. When we passno_sign_request
, we want to be able to download public files without credentials. However, we're not able to use this functionality because we do not have list permissions to the bucket.This change introduces a first check to see if an object exists using
load
(which just callshead_object
so should have very little overhead and does not require list permissions). If that does not work, we do our normal call to see if it is a dir.Downside:
1 extra network call in the case of a directory.
Bonuses:
no_sign_request
test to include scenario that failed before this fix.get
which downloads the file where we should have usedload
. Fixed this instance.rig.test_dir
folder so state on the bucket shouldn't exist. Also removed cleanup performed by_download_with_threads
in the test since it should be handled by the rig now.Closes #169