Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with mypy #61

Merged
merged 1 commit into from
May 10, 2023
Merged

Fix some issues with mypy #61

merged 1 commit into from
May 10, 2023

Conversation

drhagen
Copy link
Owner

@drhagen drhagen commented May 10, 2023

This was a failed attempt at #37. This merges are some fixes that mypy recommended. There is too much magic in Parsita to fix them all, so mypy is not made a dependency of Parsita at this time.

@codecov-commenter
Copy link

Codecov Report

Merging #61 (a5c53bd) into master (de91b9a) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          830       830           
  Branches        99        99           
=========================================
  Hits           830       830           
Impacted Files Coverage Δ
src/parsita/state/_reader.py 100.00% <ø> (ø)
src/parsita/parsers/_alternative.py 100.00% <100.00%> (ø)
src/parsita/parsers/_any.py 100.00% <100.00%> (ø)
src/parsita/parsers/_base.py 100.00% <100.00%> (ø)
src/parsita/parsers/_conversion.py 100.00% <100.00%> (ø)
src/parsita/parsers/_debug.py 100.00% <100.00%> (ø)
src/parsita/parsers/_end_of_source.py 100.00% <100.00%> (ø)
src/parsita/parsers/_literal.py 100.00% <100.00%> (ø)
src/parsita/parsers/_optional.py 100.00% <100.00%> (ø)
src/parsita/parsers/_predicate.py 100.00% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Parsita has too much magic to fix them all
@drhagen drhagen merged commit 6d64931 into master May 10, 2023
@drhagen drhagen deleted the mypy branch May 10, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants