Support for ORVIBO switch, dimmer and motion sensor #1763
Conversation
removed stray closing brace
|
@alonalon |
| @@ -3504,6 +3559,15 @@ void DeRestPluginPrivate::addSensorNode(const deCONZ::Node *node, const deCONZ:: | |||
| else if (modelId.isEmpty() && j->id() == 0x0005) // model id | |||
| { | |||
| modelId = j->toString().trimmed(); | |||
| // replace ORVIBO model ID | |||
There was a problem hiding this comment.
I'll merge this for 2.05.67 but suggest we refactor it later, so that optional translations or mappings of device model identifiers into readable text are kept in the device map.
There was a problem hiding this comment.
Yes, that sounds good. I'm guessing ORVIBO went with a GUID for the model to be able to localize their app for different countries.
I second a system that separates what the device advertises from the presentation layer. That way we can correct wrong or add missing information without putting a lot of checks all over the code.
Thanks for the merge.
This adds support for ORVIBO in-wall switch, in-wall dimmer and motion sensor. Closes #794, #1686 and #1747.