Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more switches #1127

Merged
merged 1 commit into from
Jan 13, 2019
Merged

Support more switches #1127

merged 1 commit into from
Jan 13, 2019

Conversation

ebaauw
Copy link
Collaborator

@ebaauw ebaauw commented Jan 13, 2019

@manup there's still two loose ends:

  • I cannot get deCONZ to create the binding and attribute reporting for the iCasa dimmer. Don't know what's going on; I reset and re-paired my Trådfri colour bulb, but no bindings for that either. deCONZ happily polls the lights. Even after creating the binding manually, the report configuration isn't set. After setting that manually as well, deCONZ stops polling the lights. This is my test network (2.05.54, self compiled plugin from latest commits), with only two lights (the iCasa dimmer and the Trådfri).
  • The iCasa keypads don't support attribute reporting for the battery, so deCONZ needs to poll them. The good news: they seem to poll their parent at any button click. The bad news: I'm lost were in the code to implement this - please help.

- ubisys S1, S1-R (untested), see #919;
- iCasa keypads, see #1124;
- iCasa dimmer, see #1124.
@ebaauw
Copy link
Collaborator Author

ebaauw commented Jan 13, 2019

Or maybe I'm too impatient. I now (>30 mins after starting deCONZ) see the first log message that the REST API plugin is checking the bindings.

@manup
Copy link
Member

manup commented Jan 13, 2019

Or maybe I'm too impatient. I now (>30 mins after starting deCONZ) see the first log message that the REST API plugin is checking the bindings.

That's intentional :) Since a few versions checking of bindings is delayed until it's is certain that reporting isn't active. In the meantime polling is used.

@ebaauw
Copy link
Collaborator Author

ebaauw commented Jan 13, 2019

Thanks, thats a relief.

What about the polling for the battery?

@manup
Copy link
Member

manup commented Jan 13, 2019

What about the polling for the battery?

The good news: they seem to poll their parent at any button click.

See the other comment, this needs to be schedules on a per device basis when we can be sure the device does a mac data poll after a command is received. For example if these switches do mac data polling after a button was pressed this is a good time to read battery state. Maybe with a little book keeping to do this only when the last value has a certain age.

@manup manup merged commit 8a73945 into dresden-elektronik:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants