Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for roles in grants #259

Merged
merged 21 commits into from
Jan 27, 2025
Merged

Support for roles in grants #259

merged 21 commits into from
Jan 27, 2025

Conversation

bcmeireles
Copy link
Contributor

@bcmeireles bcmeireles commented Jan 3, 2025 •
edited
Loading

Summary

Added support for roles in grants

Description

Grants can now be set for both users and for roles.
A prefix was added to handle this, with user: and role: being the valid prefixes. For example, user:dbt_test_user_1 and role:dbt_test_role_1.
If no prefix is provided, defaults to user for backwards compatibility.

Test Results

Tests were ran against a local Dremio Enterprise instance and are skipped since the current pipeline uses Dremio OSS, and grants are an Enterprise feature

Changelog

  • Added support for roles in grants

Related Issue

#177

@bcmeireles bcmeireles linked an issue Jan 3, 2025 that may be closed by this pull request
Allow grants to work with roles #177
Closed
@bcmeireles
Revert "tests"
e38fde7 
This reverts commit 8c77441.
@bcmeireles
skip grant tests
a545447 
only supported by EE/DC
current pipeline is OSS only
@bcmeireles bcmeireles marked this pull request as ready for review January 24, 2025 15:17
@99Lys 99Lys dismissed their stale review January 25, 2025 10:07

Wrong type of comment

howareyouman
howareyouman reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@howareyouman howareyouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to start adding some validations for macros parameters and add pytest feature flags for test execution.

dbt/include/dremio/macros/adapters/apply_grants.sql Show resolved Hide resolved
howareyouman
howareyouman previously approved these changes Jan 27, 2025
View reviewed changes
tests/functional/adapter/grants/test_invalid_grants.py Outdated Show resolved Hide resolved
99Lys
99Lys previously approved these changes Jan 27, 2025
View reviewed changes
@bcmeireles bcmeireles dismissed stale reviews from 99Lys and howareyouman via 180c4f8 January 27, 2025 14:47
@bcmeireles bcmeireles merged commit 0e9c546 into dremio:main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@99Lys 99Lys 99Lys approved these changes

@howareyouman howareyouman howareyouman approved these changes

@simonpannek simonpannek Awaiting requested review from simonpannek

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow grants to work with roles
4 participants
@bcmeireles @howareyouman @simonpannek @99Lys