Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled local data fetch for CTAS & limited local data fetch to 100k… #212

Closed
wants to merge 0 commits into from

Conversation

mxmarg
Copy link
Contributor

@mxmarg mxmarg commented Jan 19, 2024

See description in Dremio-internal JIRA ticket: https://dremio.atlassian.net/browse/DX-86623

@mxmarg
Copy link
Contributor Author

mxmarg commented Jan 19, 2024

Hi @awaschick, @Conq1, @ravjotbrar,
I encountered a similar issue to the one discussed here (#176), when I tried to run incremental materializations for large tables and dbt was taking hours trying to fetch the records with 100 row GET requests.
I proposed a fix to disable data fetch for CTAS queries and generally limit row fetching to the same value that Dremio's UI does (100k).
Any thoughts or criticisms on this (fairly blunt) approach?

@Conq1
Copy link

Conq1 commented Jan 23, 2024

I went the way of controlling it myself:
{% call statement('create_staging_table', fetch_result=False) -%}
{{ create_table_as(False, source_staging_relation, sql_select) }}
{%- endcall %}

But might be a good idea to force it for people less familiar with what's going on.

@ravjotbrar
Copy link
Contributor

@mxmarg Looking into this. Agree with changing the row limit size to be 500. It looks like we might be able to make fetch false by default in the code. The only time we want to fetch is when we are getting the columns of a table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants