Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Query Comment Tests #137

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Implement Query Comment Tests #137

merged 4 commits into from
Feb 23, 2023

Conversation

ravjotbrar
Copy link
Contributor

@ravjotbrar ravjotbrar commented Feb 21, 2023

Summary

Implemented the query comment tests specified by dbt, upgraded to python 3.11, and changed our adapter version to 1.4.1

Description

  • Included all query comment tests specified by dbt
  • Imported our fixtures to deal with object_storage_path issue
  • Use a default_factory to match how dbt-core instantiates the includepolicy and quotepolicy
  • Changed all instances of our adapter version to match dbt-core 1.4.1

Test Results

Query Comment Tests
ravjotb@RavjotsMacBookPro dbt-dremio % pytest tests/functional/adapter/query_comment | tee ../output.txt
============================= test session starts ==============================
collected 6 items

tests/functional/adapter/query_comment/test_query_comment.py ......      [100%]

======================= 6 passed, 12 warnings in 41.61s ========================
Basic Tests
ravjotb@RavjotsMacBookPro dbt-dremio % pytest tests/functional/adapter/basic | tee ../output.txt
============================= test session starts ==============================

tests/functional/adapter/basic/test_adapter_methods.py .                 [  5%]
tests/functional/adapter/basic/test_base_mat.py .                        [ 11%]
tests/functional/adapter/basic/test_concurrency.py .                     [ 16%]
tests/functional/adapter/basic/test_current_timestamp.py ..              [ 27%]
tests/functional/adapter/basic/test_data_types.py .                      [ 33%]
tests/functional/adapter/basic/test_docs_generate.py ...                 [ 50%]
tests/functional/adapter/basic/test_empty.py .                           [ 55%]
tests/functional/adapter/basic/test_ephemeral.py .                       [ 61%]
tests/functional/adapter/basic/test_generic_tests.py .                   [ 66%]
tests/functional/adapter/basic/test_incremental.py ..                    [ 77%]
tests/functional/adapter/basic/test_singular_ephemeral.py .              [ 83%]
tests/functional/adapter/basic/test_singular_tests.py .                  [ 88%]
tests/functional/adapter/basic/test_snapshots.py s.                      [100%]

============ 17 passed, 1 skipped, 43 warnings in 877.36s (0:14:37) ============
Grants Tests
ravjotb@RavjotsMacBookPro dbt-dremio % pytest tests/functional/adapter/grants | tee ../output.txt
============================= test session starts ==============================

tests/functional/adapter/grants/test_incremental_grants.py .             [ 16%]
tests/functional/adapter/grants/test_invalid_grants.py .                 [ 33%]
tests/functional/adapter/grants/test_model_grants.py ..                  [ 66%]
tests/functional/adapter/grants/test_seed_grants.py .                    [ 83%]
tests/functional/adapter/grants/test_snapshot_grants.py .                [100%]

================== 6 passed, 18 warnings in 496.13s (0:08:16) ==================

Changelog

  • Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue

#117

@ravjotbrar ravjotbrar requested a review from ArgusLi February 21, 2023 19:38
Copy link
Contributor

@ArgusLi ArgusLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravjotbrar
Copy link
Contributor Author

Successfully ran a subset of tests against python 3.10 to ensure backwards compatibility. Merging.

@ravjotbrar ravjotbrar merged commit 2bb213b into main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants