Sets a default pool size for Windows as Process::RLIMIT_NOFILE is not supported #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 can we get this merged. I am on windows and I am getting this bug |
BrianPurgert
approved these changes
Jun 15, 2018
|
+1 can we get this merged? |
|
Please merge this! |
|
+1 Please merge |
|
Can we get this merged? |
|
Has this still not been merged? |
|
It's not clear if this has been merged. Can you merge this if it isn't please? It would be a huge help! |
|
This is straightforward and allows this gem to be used under Windows. Can we merge it? |
|
@drbrain, I saw that you have merged couple PRs in recently and I'm not sure who else has merge privileges... Was wondering if this can be merged in; this currently breaks functionality on Windows. Thanks! |
8 tasks
|
@drbrain Along with this merge, are you going to cut a new release soon? |
ghost
pushed a commit
to rubygems/bundler
that referenced
this pull request
Jul 25, 2019
7200: Bump net-http-persistent to 3.1.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I wanted to propose some changes to this vendored gem, but I found out that we are using an old version of it. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade the dependency. Since it's a major update, it required some changes. Also, I had to: * Add a new artifice task to vendorize new `connection_pool` dependency. This is the main downside of this PR, that the new version adds a dependency on this gem. But this gem is very stable, and rarely changes and releases new versions, as can be seen by its [releases](https://github.com/mperham/connection_pool/releases). * Cherry-pick a Windows fix not yet merged into master branch of `net-http-persistent`: drbrain/net-http-persistent#90. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
ghost
pushed a commit
to rubygems/bundler
that referenced
this pull request
Jul 25, 2019
7200: Bump net-http-persistent to 3.1.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I wanted to propose some changes to this vendored gem, but I found out that we are using an old version of it. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade the dependency. Since it's a major update, it required some changes. Also, I had to: * Add a new artifice task to vendorize new `connection_pool` dependency. This is the main downside of this PR, that the new version adds a dependency on this gem. But this gem is very stable, and rarely changes and releases new versions, as can be seen by its [releases](https://github.com/mperham/connection_pool/releases). * Cherry-pick a Windows fix not yet merged into master branch of `net-http-persistent`: drbrain/net-http-persistent#90. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
8 tasks
ghost
pushed a commit
to rubygems/rubygems
that referenced
this pull request
Mar 11, 2020
7200: Bump net-http-persistent to 3.1.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I wanted to propose some changes to this vendored gem, but I found out that we are using an old version of it. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade the dependency. Since it's a major update, it required some changes. Also, I had to: * Add a new artifice task to vendorize new `connection_pool` dependency. This is the main downside of this PR, that the new version adds a dependency on this gem. But this gem is very stable, and rarely changes and releases new versions, as can be seen by its [releases](https://github.com/mperham/connection_pool/releases). * Cherry-pick a Windows fix not yet merged into master branch of `net-http-persistent`: drbrain/net-http-persistent#90. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets a default pool size for Windows as Process::RLIMIT_NOFILE is not supported on the OS.
Fixes #79