Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 8333396: Use StringBuilder internally for java.text.Format.* formatting #85

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lingjun-cg
Copy link
Collaborator

[Backport] 8333396: Use StringBuilder internally for java.text.Format.* formatting

Summary: java.text.Format.* use StringBuffer internally, but StringBuffer's bad performance character become obvious after obsoleting biased locking. So use StringBuilder if possible in java.text.Formating.*.

Testing: All java.text.format jtreg.

Reviewers: D-D-H, Yude Lin

Issue: #83

….* formatting

Summary: java.text.Format.* use StringBuffer internally, but StringBuffer's bad performance character become obvious after obsoleting biased locking. So use StringBuilder if possible in java.text.Formating.*.

Testing: All java.text.format jtreg.

Reviewers: D-D-H, Yude Lin

Issue: dragonwell-project#83
@lingjun-cg lingjun-cg requested review from linade and D-D-H July 22, 2024 06:41
Copy link
Collaborator

@D-D-H D-D-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@linade
Copy link
Collaborator

linade commented Jul 22, 2024

Is this a clean backport?

@linade
Copy link
Collaborator

linade commented Jul 22, 2024

Also does it change any public api that might break any existing dw21 applications

@linade
Copy link
Collaborator

linade commented Jul 23, 2024

lgtm, effectively clean backport without touching public api, only some description changes

@lingjun-cg
Copy link
Collaborator Author

Also does it change any public api that might break any existing dw21 applications

No public api changed.

@lingjun-cg
Copy link
Collaborator Author

Is this a clean backport?

Yes. There are only some minor conflicts at the topmost of file that contains "Copyright ".

@lingjun-cg lingjun-cg merged commit 102db0f into dragonwell-project:master Jul 23, 2024
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants