[Backport] 8333462: Performance regression of new DecimalFormat() when compare to jdk11 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n compare to jdk11 Summary: The DecimalFormat constructor calls DecimalFormatSymbols.findNonFormatChar(String,char) multiple times, and the lambda implementation of findNonFormatChar is slow than plain loop implementation. Testing: All java.text.format jtreg. Reviewers: D-D-H, Yude Lin Issue: dragonwell-project#79
|
Nice. Someone is backporting this to the jdk21u upstream. As I understand, we not waiting for that because we want this in the next release? |
linade
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backport] 8333462: Performance regression of new DecimalFormat() when compare to jdk11
Summary: The DecimalFormat constructor calls DecimalFormatSymbols.findNonFormatChar(String,char) multiple times, and the lambda implementation of findNonFormatChar is slow than plain loop implementation.
Testing: All java.text.format jtreg.
Reviewers: D-D-H, Yude Lin
Issue: #79