bug(replication): snapshot cleanup fix in transition to stable sync #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
|
Log file created at: 2024/11/13 15:33:04 |
Signed-off-by: adi_holden <adi@dragonflydb.io>
kostasrim
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
💯
plz wait for https://github.com/dragonflydb/dragonfly/actions/runs/12052175176
before you merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug:
In case of socket error inside StopFullSyncInThread we would overide the cleanup function in StartStableSyncInThread as we will call it even if the StopFullSyncInThread failed, causing the reset of saver not in his shard thread
The fix:
return error status from StopFullSyncInThread and incase of error dont call StartStableSyncInThread