Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Helm chart): Add env vars into pods #4196

Merged
merged 13 commits into from
Dec 2, 2024
Merged

Feat(Helm chart): Add env vars into pods #4196

merged 13 commits into from
Dec 2, 2024

Conversation

andreibe24
Copy link
Contributor

The current change is required to allow use of S3 bucket backups.

@chakaz
Copy link
Collaborator

chakaz commented Nov 26, 2024

@Pothulapati would it be at all possible for you to take a look? 🙏

andreibe24 and others added 5 commits November 26, 2024 09:27
@andreibe24
feat: update pod template
4dac4b9 
Signed-off-by: andreibe <95860450+andreibe24@users.noreply.github.com>
@andreibe24
fix: remove duplicate
259015d 
Signed-off-by: andreibe <95860450+andreibe24@users.noreply.github.com>
@andreibe24
feat: update chart values.yaml
20dc128 
Signed-off-by: andreibe <95860450+andreibe24@users.noreply.github.com>
@andreibe24
feat: update README.md
14c1df1 
Signed-off-by: andreibe <95860450+andreibe24@users.noreply.github.com>
@andreibe24
fix: change template behaviour on env
62020df 
Signed-off-by: andreibe <andreibe24@users.noreply.github.com>
@romange romange requested a review from Pothulapati November 26, 2024 20:39
Pothulapati
Pothulapati requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly loooks right.

Can you add a example/test-case in a new values file under the /contrib/charts/dragonfly/ci', run go test ./... --update` and make sure the output is what we expect and won't break with other changes in the future?

Thanks

andreibe24 and others added 2 commits November 27, 2024 18:47
@andreibe24
Merge branch 'dragonflydb:main' into feat/helm_env
7a54700
@andreibe24
chore: add helm ci tests
e6fc49c 
Signed-off-by: andreibe <andreibe24@users.noreply.github.com>
@andreibe24
Copy link
Contributor Author

Hi @Pothulapati,
I've posted the CI helm tests.

Yours,
Andrei B

andreibe24 and others added 5 commits November 28, 2024 05:12
@andreibe24
fix: rerun go test
e09575b 
Signed-off-by: andreibe <andreibe24@users.noreply.github.com>
@andreibe24
Merge branch 'dragonflydb:main' into feat/helm_env
47c12a6
@andreibe24
test: add extra manifests
976d1ce 
Signed-off-by: andreibe <andreibe24@users.noreply.github.com>
@andreibe24
Merge branch 'dragonflydb:main' into feat/helm_env
417602f
@andreibe24
fix: ci tests
6dc660d 
Signed-off-by: andreibe <andreibe24@users.noreply.github.com>
@romange romange requested review from romange and Pothulapati and removed request for Pothulapati November 30, 2024 17:58
Pothulapati
Pothulapati approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pothulapati Pothulapati enabled auto-merge (squash) December 2, 2024 07:37
@Pothulapati Pothulapati merged commit ada96d9 into dragonflydb:main Dec 2, 2024
9 checks passed
@andreibe24 andreibe24 deleted the feat/helm_env branch December 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pothulapati Pothulapati Pothulapati approved these changes

@romange romange Awaiting requested review from romange

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreibe24 @chakaz @romange @Pothulapati