feat(server): add eval_ro and evalsha_ro #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
reviewed
Nov 13, 2024
dranikpg
previously approved these changes
Nov 16, 2024
| @@ -176,7 +176,8 @@ void Transaction::Shutdown() { | |||
| Transaction::Transaction(const CommandId* cid) : cid_{cid} { | |||
| InitTxTime(); | |||
| string_view cmd_name(cid_->name()); | |||
| if (cmd_name == "EXEC" || cmd_name == "EVAL" || cmd_name == "EVALSHA") { | |||
| if (cmd_name == "EXEC" || cmd_name == "EVAL" || cmd_name == "EVAL_RO" || cmd_name == "EVALSHA" || | |||
There was a problem hiding this comment.
I hope you checked all places with "EVAL" 🙂 We use some more in main_service.cc, we use abs::StartsWith to be more compact.
There was a problem hiding this comment.
There was a problem hiding this comment.
I hope you checked all places with "EVAL" 🙂 We use some more in main_service.cc, we use abs::StartsWith to be more compact.
I think so yeah - the StartsWith ones are ok as will match EVAL_RO? Or do you mean some shouldn't match
6bfdacd to
e15e752
Compare
chakaz
approved these changes
Nov 24, 2024
|
Thanks Andy! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3880 and #3879