feat(server): Implemented periodic snapshotting (#161) #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(test): Added the ability to specify dragonfly cli parameters on a test basis (dragonflydb#199) Signed-off-by: Braydn <braydn.moore@uwaterloo.ca>
romange
reviewed
Aug 22, 2022
|
Thanks, I will review it shortly! :) Please join our discord and say hello! :) |
|
Awesome contribution and thanks for raising the bar with pytest code! 💯 |
romange
requested changes
Aug 22, 2022
This was
linked to
issues
Aug 22, 2022
Closed
Code cleanup & CONTRIBUTORS.md modifcation Signed-off-by: Braydn <braydn.moore@uwaterloo.ca>
romange
requested changes
Aug 23, 2022
romange
reviewed
Aug 23, 2022
src/server/server_family.cc
Outdated
| snapshot_fiber_ = service_.proactor_pool().GetNextProactor()->LaunchFiber([save_spec = std::move(spec.value()), this] { | ||
| SnapshotScheduling(std::move(save_spec)); | ||
| }); | ||
| } |
There was a problem hiding this comment.
formatting is wrong here. "else" should be on the same line with "} "
romange
reviewed
Aug 23, 2022
src/server/server_family.cc
Outdated
| }); | ||
| } | ||
| else { | ||
| LOG(WARNING)<<"Invalid snapshot time specifier "<<save_time; |
Parsing and race condition fixes. Improved pytests Signed-off-by: Braydn <braydn.moore@uwaterloo.ca>
romange
reviewed
Aug 24, 2022
romange
reviewed
Aug 24, 2022
tests/pytest/snapshot_test.py
Outdated
| import time | ||
| import os | ||
|
|
||
| OUT_DIR = TemporaryDirectory() |
romange
reviewed
Aug 24, 2022
tests/pytest/snapshot_test.py
Outdated
| @@ -0,0 +1,28 @@ | |||
| from pathlib import Path | |||
| from tempfile import TemporaryDirectory | |||
|
@romange I ended up cleaning up the test cases and adding documentation for writing tests to the README file. Do you want those changes included in this PR or should I open a new one focused on test changes? |
|
It's fine adding here @braydnm |
…#199) - Moved tests into their own file - Renamed test namespace to avoid naming conflicts with pytest - Updated requirements.txt to make test environment reproducible - Added documentation to write tests feat(server): Updated helio submodule Signed-off-by: Braydn <braydn.moore@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Braydn braydn.moore@uwaterloo.ca