Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: MVariable added + MArray.remove_elem() added + MArray.append_elem() changed + MArray label and fetch method added + Generic MArrayElement sub-mobjects fetch method added + MArrayElementComp enum added + Changed array.py to m_array.py + Documentation updated #1

Merged
merged 3 commits into from
Dec 10, 2022

Conversation

drageelr
Copy link
Owner

@drageelr drageelr commented Dec 10, 2022

Overview: What does this pull request change?

  • Added remove element function in MArray
  • Added label support in MArrayElement
  • Added generic mob fetch function in MArrayElement coupled with MArrayElementComp enum
  • Changed array.py to m_array.py because of conflict with native array module
  • Added variables documentation in references
  • Updated module name of m_array in references
  • Label with four different direcitons added.
  • Label shifts on append and remove element appropriately.
  • Update label text doesn't remove previous label, therefore not added in this commit.
  • Method to fetch array label.
  • Documentation updated to reflect the changes.

Motivation and Explanation: Why and how do your changes improve the library?

  • Can now append/remove elements to/from MArray using custom animations.
  • Can now have label with MArray in all four directions that shifts whenever elements are added/removed to/from the MArray.
  • Can now create and manipulate variables using MVariable.

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section

* Added remove element function in MArray
* Added label support in MArrayElement
* Added generic mob fetch function in MArrayElement coupled with MArrayElementComp enum
* Changed array.py to m_array.py because of conflict with native array module
* Added variables documentation in references
* Updated module name of m_array in references
* Label with four different direcitons added.
* Label shifts on append and remove element appropriately.
* Update label text doesn't remove previous label, therefore not added in this commit.
* Method to fetch array label.
@drageelr drageelr marked this pull request as ready for review December 10, 2022 16:56
@drageelr drageelr merged commit 5759440 into dev Dec 10, 2022
@drageelr drageelr deleted the drageelr-dev branch December 12, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant