Remove False Positive Errors When Using 'livenet' And Squashfs #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FedericoVaga Thanks. 1./ Can you please change the title of both commit messages from to 2./ Also can you please rebase on top of latest master so that "Pull Request Labeler" is green ? |
Looking for directories in `/sys/fs` is not exhaustive. Not all available filesystems are listed there. A library function has been already developed for such a use case. It is `load_fstype``. This patch replaces custom code with a call to `load_fstype` Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
3e64129 to
dbaf3d3
Compare
|
@LaszloGombos |
LaszloGombos
approved these changes
Mar 12, 2024
| systemctl start checkisomd5@"${p}".service | ||
| else | ||
| checkisomd5 --verbose "$check_dev" | ||
| # Check ISO checksum only If we have a path to a block device (or just its name |
| checkisomd5 --verbose "$check_dev" | ||
| # Check ISO checksum only If we have a path to a block device (or just its name | ||
| # without '/dev'). In other words, in this context, we perform the check only | ||
| # if the give $livedev is not a filesystem file image. |
The ISO checksum code was executed independently of the provided `$livedev`. Often, this is a loop device pointing to an ISO image, but in other cases `dmsquash-live-root` receives the path to a filesystem image. In this case, we can't use `udevadm` to extract information because it is not a device, and trying to do that leads to `udevadm` error messages (but not blocking). Therefore, the ISO checksum check must be performed only if the provided `$livedev` is **not** a regular file. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
dbaf3d3 to
c8f1708
Compare
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
Hi all, is there something I should do to make this pull-request move forward? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes...
Changes
Remove the following false positive error messages when using a squashfs image using the livenet module
modprobecan'tsquashfsdriver when actually it is built-in in the kerneldmsquash-live-roottrying to verify the ISO checksum for a squashfs filesystem file imageChecklist
Fixes #