-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dmsquash-live): handle relative pathspec #2253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is required to make the following canonical example work that is mentioned in the documentation
Are we sure that the example in the man page (pathspec
not starting with / ) is correct?
If the answer is yes, wouldn't it be easier to just fix when pathspec
is assigned and doesn't start with / , to avoid the "//" case?
pathspec=${overlay##*:} |
7016f8f
to
ed5b4b9
Compare
I think the example in the documentation can be improved. I added the improvement in the doc to this PR as well. Regardless this example has been in the documentation for 7 years, and maintaining compatibility with this example seems to be simple enough.
Thanks for this, great catch. I made the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that the example in the man page (
pathspec
not starting with / ) is correct?I think the example in the documentation can be improve. I added the improvement in the doc to this PR as well.
Regardless this example has been in the documentation for 7 years, and maintaining compatibility with this example seems to be simple enough.
What I meant was I haven't found any example of pathspec
without starting with /, because it refers to a file path.
This change is required to make the earlier canonical example work that is mentioned in the documentation: At the same time, improve the documentation with a more specific example.
ed5b4b9
to
ece24db
Compare
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
This change is required to make the following canonical example work that is mentioned in the documentation:
This example has been in the dracut documentation since 2015.
At the same time, improve the documentation with a more specific example.
Checklist
Fixes #579 (partially)
CC @FGrose @Conan-Kudo @fabiand