fix(dracut.sh): split drivers_dir check #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory where to look for kernel modules can be set via the -k/--kmoddir command line option or the drivers_dir configuration option. Its current check should be split into two different ones to avoid misleading error messages (see referenced issue): - First check that its basename matches the kernel version set for the initramfs (via --kver or automatically set by "uname -r"). - Second check that the parent directory of the last provided directory contains "/lib/modules/". This check was also fixed to avoid accepting other directories like "xxxlib/modules". Fixes issue dracutdevs#1608
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
johannbg
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory where to look for kernel modules can be set via the
-k/--kmoddircommand line option or thedrivers_dirconfiguration option. Its current check should be split into two different ones to avoid misleading error messages (see #1608):--kveror automatically set byuname -r).Checklist
Fixes #1608