Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gha release #94

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Update gha release #94

merged 3 commits into from
Aug 21, 2023

Conversation

jmctune
Copy link
Contributor

@jmctune jmctune commented Aug 21, 2023

The idea here is:

  • Any commits to main will build a "dev" version of the current tag
    • If we are on tag v4.0.0, a commit to main will make a pre-release and tag for v4.0.0-dev
    • This was changed from automatically converting to v4.1.0 because this assumes the next tag already. We don't know what the next version will immediately be.
  • Any existing assets attached to the dev release will be deleted and the latest zip will be attached instead
  • When a new tag is pushed to the repository, the same tag (minus the v) will be written to the version.update file and committed
  • We move the tag to the commit that made the change to version.updateso so that the tag includes the version bump
  • This also kicks off a new official release with the tag that was pushed

It's similar to before, but there is no more PR -> dev -> main workflow. It's just PR -> main. main will act as dev until it has been tagged, which will then turn into a release. PRs shouldn't make their way into main without testing and there shouldn't be any direct pushes to main without going through a PR first.

@jmctune jmctune self-assigned this Aug 21, 2023
@jmctune jmctune merged commit ee88471 into main Aug 21, 2023
@jmctune jmctune deleted the update-gha-release branch August 21, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant