separate monster and npc names #72
Conversation
app/clarity.py
Outdated
| @@ -140,7 +142,12 @@ def scan_for_npc_names(): | |||
| name_addr = address + 48 # jump to name | |||
| name = read_string(name_addr) | |||
|
|
|||
| if data == "NPC": | |||
| if data == "NPC" or data == "MONSTER": | |||
| translated_names = '' | |||
There was a problem hiding this comment.
You don't need to assign an empty string here as your conditional below is already assigning this variable. It won't end up unassigned with this logic.
app/clarity.py
Outdated
| if data == "NPC": | ||
| if data == "NPC" or data == "MONSTER": | ||
| translated_names = '' | ||
| if data == "NPC": |
There was a problem hiding this comment.
You can assign these in the if/else above on lines 133 and 135 to dry this out.
app/clarity.py
Outdated
| @@ -140,7 +144,7 @@ def scan_for_npc_names(): | |||
| name_addr = address + 48 # jump to name | |||
| name = read_string(name_addr) | |||
|
|
|||
| if data == "NPC": | |||
| if data == "NPC" or data == "MONSTER": | |||
There was a problem hiding this comment.
Extra whitespace after MONSTER:.
app/clarity.py
Outdated
| f"{misc_files}/smldt_msg_pkg_NPC_DB.win32.json", | ||
| f"{misc_files}/custom_npc_names.json" | ||
| ]) | ||
| translated_monster_names = f"{misc_files}/subPackage02Client.win32.json" |
There was a problem hiding this comment.
This just came to me, but I realized that this isn't actually doing anything other than assigning the path to a string. We need to actually read the contents and assign it to something that we can look up.
For now, the easiest way would be to just call merge_jsons() on this string (like above) to produce a separate dict.
|
npc and monster names are still translating correctly with these changes. |
No description provided.