add new network text hook. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to differentiate.
…a custom log for us to obtain.
…is hook in case we find another string we might want to translate.
…sier. It's way harder writing code in a big string with no linter.
|
/build |
|
/build |
|
/build |
when navigating to the project root. Calling get_project_root() is
so much cleaner.
- Fixes a lot of logging inconsistencies. Specifically:
- console.log is now being re-created on each run
- functions that were being called through multiprocessing were not
getting logged to file as the handler is not global when spawning
a new process. We now set up logging in functions that are only
called from multiprocessing
- Remove noise when you run dqxclarity twice, which can't happen since
the integrity address pattern will no longer match. Added an error
message informing the user what to do when this happens.
- Changed messaging when you have community logging enabled.
- Typo: structure
- Phasing out "debug" use throughout the application. This application
is given to non-technical users and trying to figure out an issue
with it turned off is impossible. Can't fully remove it as
DQXClarity.exe will throw an exception when calling dqxclarity if it
doesn't exist.
- Fix NetworkTextTranslate for story_so_far. Game changed some bytes
I was relying on to figure out the difference between story_so_far
and monster trivia. Instead, we'll check if the text is English as
monster trivia should almost always be in English. We'll look at the
database instead and do nothing if there is no match, as we should
have all story_so_far strings.
…me isn't running anymore.
|
/build |
|
Link to workflow: https://github.com/dqx-translation-project/dqxclarity/actions/runs/6442524408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playertable. We aren't using this for anything right now, but available for the futurestory_so_fartext frommerge.xlsxin dqx-custom-translations into the db on player login. This is populated on each login to support multiple charactersMultiprocessinglogsfolder