Admin protocol updates #1948
Merged
Admin protocol updates #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLubeck
commented
Nov 8, 2019
| ('config_names', String('utf-8')), | ||
| ('config_value', String('utf-8')), | ||
| ('read_only', Boolean), | ||
| ('config_source', Int8), |
There was a problem hiding this comment.
It looks like this was renamed from is_default to config_source, and the type changed from Boolean to Int8 in v1 as well, but I didn't include that fix here. Should I?
There was a problem hiding this comment.
Ugh. I do hate to make breaking changes... But I could go either way on this one.
c51d814 to
68d8aad
Compare
added 6 commits
November 8, 2019 15:21
68d8aad to
fa35d52
Compare
|
I know how this sounds, but I can't for the life of me reproduce the test failure locally. Any suggestions? |
added 2 commits
November 15, 2019 10:24
python > 3.3 will error at runtime so while this test is extraneous it'll help catch typos like this
|
Test failure is known to be flakey and has been marked as xfail in master (see #1929) |
dpkp
approved these changes
Dec 29, 2019
| ('config_names', String('utf-8')), | ||
| ('config_value', String('utf-8')), | ||
| ('read_only', Boolean), | ||
| ('config_source', Int8), |
There was a problem hiding this comment.
Ugh. I do hate to make breaking changes... But I could go either way on this one.
| @@ -988,6 +999,9 @@ def describe_consumer_groups(self, group_ids, group_coordinator_id=None): | |||
| useful for avoiding extra network round trips if you already know | |||
| the group coordinator. This is only useful when all the group_ids | |||
| have the same coordinator, otherwise it will error. Default: None. | |||
| :param include_authorized_operatoins: Whether or not to include | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been digging in to the admin client and found myself adding extra api version support
This change is