1.4.7

[ofek]

@dpkp Hello there! Are there any blockers for releasing 1.4.7? If so, can I help?

[dpkp]

There are two things on my mind: (1) consumer performance degradation in #1888 . I have attempted to fix w #1902 but it is a significant internal change and so has risk. I haven't decided whether to make this the default and allow opt out or make it opt in and wait for a 1.5 release to make it the default. (2) Heartbeat thread coordination / deadlocks / timeouts remain an issue. One structural change that I have deferred is in #1821 . I am undecided whether to make this change now or in the future after thinking more about the deadlock issue I mention in the comments. (3) I would like to make some changes to the network write IO so that we use non blocking socket send() with a buffer and also improve error handling. I have done some work on this already but haven't put up a PR. If you'd like to pitch in, maybe just give me your thoughts on these issues. How would you manage them?

…

On Wed, Sep 18, 2019, 10:32 AM Ofek Lev ***@***.***> wrote: @dpkp <https://github.com/dpkp> Hello there! Are there any blockers for releasing 1.4.7? If so, can I help? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1903?email_source=notifications&email_token=AAGN5NHV5YX2BFFBVHU6N4DQKJQ3PA5CNFSM4IYBWBA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMGTKQQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGN5NEJ7F5OWS5ZYE7X4E3QKJQ3PANCNFSM4IYBWBAQ> .

[dpkp]

Also I need to learn to count to three.

[ofek]

@dpkp Thanks for the thoughtful response!

1. I'm very sensitive to performance regressions in general, though since it's been a few releases now, I would merge your fix as-is and change the default in a minor release.
2. I'd wait for a minor release.
3. I think that's a good idea but not a blocker for this release.

However, you should know I'm biased for 2 reasons:

1. We're actively waiting to merge PRs that depend on functionality that will be introduced in 1.4.7 😄
2. As a fellow maintainer of OSS in my free time, my personal approach is to release incrementally, as often as possible.

[ofek]

What do you think?

[iAnomaly]

Thanks for pushing on this @ofek. I've also tried to get @jeffwidman and @dpkp to cut a patch release since Aug 16 to include my PR #1883 as it resolves handshake failures for unknown root CAs such as Amazon's that are blocking downstream projects such as Datadog's Kafka consumer integration.

[ofek]

@dpkp Any progress on this?

[dpkp]

Hi team - I'll take a stab this weekend!

…

On Wed, Sep 25, 2019, 9:45 PM Ofek Lev ***@***.***> wrote: @dpkp <https://github.com/dpkp> Any progress on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1903?email_source=notifications&email_token=AAGN5NAT7QVDIOAEGCEOETTQLQ45ZA5CNFSM4IYBWBA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UIQJA#issuecomment-535332900>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGN5NFZCRBWTU2WMGGXQ5LQLQ45ZANCNFSM4IYBWBAQ> .

[ofek]

@dpkp Great, thanks!

[dpkp]

1.4.7 released + uploaded to pypi. Please report any issues!

[ofek]

@dpkp Thank you so much!

[jeffwidman]

Thanks for all your hard work on this @dpkp!