fix: relax marshmallow-sqlalchemy version constraint to fix compatibility with marshmallow>=3.24 #2298
+73
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th marshmallow>=3.24
|
given that marshmallow 4.0 will be released soon, i also think the version constraint for marshmallow should also be relaxed to but this can happen as a follow-up |
|
Nice one - would be great to get it in :) |
sloria
commented
Jan 9, 2025
| @@ -58,7 +58,7 @@ def desc(): | |||
| "Flask-JWT-Extended>=4.0.0, <5.0.0", | |||
| "jsonschema>=3, <5", | |||
| "marshmallow>=3.18.0, <4", | |||
| "marshmallow-sqlalchemy>=0.22.0, <0.29.0", | |||
| "marshmallow-sqlalchemy>=0.22.0, <2.0.0", | |||
There was a problem hiding this comment.
IMO we should remove the upper bound altogether
Suggested change
| "marshmallow-sqlalchemy>=0.22.0, <2.0.0", | |
| "marshmallow-sqlalchemy>=0.22.0", |
to avoid issues like the one that Airflow ran into. since FAB is a library, its shouldn't impose such strict upper constraints on its dependencies and allow users to pin their own dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relax the upper marshmallow-sqlalchemy version constraint. This is necessary for compatibility with newer versions of marshmallow (>=3.24.0).
This would resolve this issue in Airflow: apache/airflow#45442 (comment)
This also upgrades a few dependencies needed for a working development environment (used
pip-compile --upgrade-package ...).ADDITIONAL INFORMATION