Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance _get_list_widget and _list methods to accept additional kwargs #2285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gugupy
Copy link
Contributor

@gugupy gugupy commented Nov 3, 2024

Description

This refactor improves the _get_list_widget and _list methods by adding support for additional keyword arguments (**kwargs). The main changes include:

  • Modified _get_list_widget to accept and pass **kwargs to self.list_widget, allowing more flexibility in handling dynamic arguments.
  • Updated _list to accept **kwargs and pass them to _get_list_widget, enabling the method to adapt to various contexts where additional parameters may be required.
  • These changes enhance extensibility and make the codebase more adaptable to future enhancements without needing to modify the method signatures repeatedly.

Example Usage

# Now you can pass additional options like 'custom_setting' directly
widgets = self._list(custom_setting="example")

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant