Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old API api column edit #2134

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix: old API api column edit #2134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba36050
fix: old API api column edit
dpgaspar Oct 13, 2023
0e9fcaa
fix lint
dpgaspar Oct 13, 2023
0bbb03b
Merge branch 'master' into fix/old-api-edit-col
dpgaspar Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flask_appbuilder/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@
log.warning("This API is deprecated and will be removed on 2.3.X")
filter_rel_fields = None
if self.edit_form_query_rel_fields:
filter_rel_fields = self.edit_form_query_rel_fields
filter_rel_fields = self.edit_form_query_rel_fields.get(col_name)

Check warning on line 474 in flask_appbuilder/views.py

View check run for this annotation

Codecov / codecov/patch

flask_appbuilder/views.py#L474 

Added line #L474 was not covered by tests
ret_json = self._get_related_column_data(col_name, filter_rel_fields)
response = make_response(ret_json, 200)
response.headers["Content-Type"] = "application/json"
Expand Down