Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1593] handle no items in card carousel #909

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

dylankelly
Copy link
Contributor

…ms in carousel

Issue:

What I did

  • Added check for items in TideLandingPAgeCardCarousel to not display title if there are no items
  • Added conditional in RplCardCarousel in computed property to prevent fatal error

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@dylankelly dylankelly self-assigned this Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit e9a1af4
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65374a63af8e6b00088a2f88

@cypress
Copy link

cypress bot commented Oct 24, 2023

Passing run #849 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-landing-page): 🐛 handle case when no items in carou...
Project: ripple-framework Commit: e9a1af4011
Status: Passed Duration: 05:20 💡
Started: Oct 24, 2023 4:39 AM Ended: Oct 24, 2023 4:45 AM

Review all test suite changes for PR #909 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Oct 24, 2023
Merged via the queue into develop with commit 51b643e Oct 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants