Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1585] Filter out alerts with missing type relation #901

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1585

What I did

  • The site API call is returning incomplete alert nodes if they are associated via primary site ID, but not site ID
  • Our API firehose _src clearly shows these nodes, but linking direct to the BE API source does not
  • For now, just filtering out any incomplete alert node to prevent the site from exploding (it really shouldn't), but will need to figure out why we're seeing those records in the first place

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 528e65e
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/652f5c2f76217900086983aa

@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #830 ↗︎

0 99 0 0 Flakiness 0

Details:

Merge branch 'develop' into fix/r20-1585-unassigned-site-alert
Project: ripple-framework Commit: 528e65e2c6
Status: Passed Duration: 05:09 💡
Started: Oct 18, 2023 4:40 AM Ended: Oct 18, 2023 4:45 AM

Review all test suite changes for PR #901 ↗︎

@dylankelly dylankelly disabled auto-merge October 18, 2023 07:24
@dylankelly dylankelly merged commit 26cc4ae into develop Oct 18, 2023
@waitingallday waitingallday deleted the fix/r20-1585-unassigned-site-alert branch October 25, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants