Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/nuxt-ripple): ensured that language specific fonts override all other fonts #876

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(@dpc-sdp/nuxt-ripple): ensured that language specific fonts override all other fonts #876

merged 1 commit into from
Oct 9, 2023

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

  • After the custom font change, the language css selector was no longer specific enough to override the fonts

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Oct 4, 2023
@netlify
Copy link

netlify bot commented Oct 4, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 80c2d1a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/651ded84c512c00008231264

@cypress
Copy link

cypress bot commented Oct 4, 2023

Passing run #761 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/nuxt-ripple): ensured that language specific fonts override all oth...
Project: ripple-framework Commit: 80c2d1aa98
Status: Passed Duration: 07:54 💡
Started: Oct 4, 2023 10:59 PM Ended: Oct 4, 2023 11:07 PM

Review all test suite changes for PR #876 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Oct 9, 2023
Merged via the queue into develop with commit b60fe07 Oct 9, 2023
@waitingallday waitingallday deleted the feature/R20-1533-custom-font branch October 25, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday waitingallday approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @waitingallday @dylankelly