Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1306] Hyphenate titles #824

Merged
merged 5 commits into from
Sep 5, 2023
Merged

[R20-1306] Hyphenate titles #824

merged 5 commits into from
Sep 5, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1306

What I did

  • Added hyphenation CSS to headings

How to test

  • Storybook

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Aug 31, 2023
@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit ead29a8
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64f7bcbd5f3fc400088f5183

@cypress
Copy link

cypress bot commented Aug 31, 2023 •
edited
Loading

Passing run #617 ↗︎

0 96 0 0 Flakiness 0

Details:

Merge branch 'develop' into task/r20-1306-hyphenate-titles
Project: ripple-framework Commit: ead29a8edb
Status: Passed Duration: 05:10 💡
Started: Sep 5, 2023 11:45 PM Ended: Sep 5, 2023 11:50 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly marked this pull request as ready for review September 5, 2023 00:43
@dylankelly dylankelly self-requested a review September 5, 2023 00:43
dylankelly
dylankelly approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant say we didnt warn them

@dylankelly dylankelly enabled auto-merge September 5, 2023 00:44
@dylankelly dylankelly added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit 3f0043a Sep 5, 2023
@lambry lambry deleted the task/r20-1306-hyphenate-titles branch September 22, 2023 04:30
@waitingallday waitingallday mentioned this pull request Oct 18, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@lambry lambry lambry approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @lambry @dylankelly