Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-652] search banner feedback #1425

Merged
merged 1 commit into from
Jan 19, 2025
Merged

[SD-652] search banner feedback #1425

merged 1 commit into from
Jan 19, 2025

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 17, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-652

What I did

  • Adds extra space between text in input on desktop

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.24.0 milestone Jan 17, 2025
@lambry lambry self-assigned this Jan 17, 2025
@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025

ripple-framework    Run #2507

Run Properties:  status check passed Passed #2507  •  git commit aa3a9b7a3b: style(@dpc-sdp/ripple-ui-core): increase search banner margin on large screen
Project ripple-framework
Branch Review feature/search-banner-feedback
Run status status check passed Passed #2507
Run duration 10m 11s
Commit git commit aa3a9b7a3b: style(@dpc-sdp/ripple-ui-core): increase search banner margin on large screen
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@lambry lambry merged commit 1d1bd6c into release/2.24.0 Jan 19, 2025
13 of 14 checks passed
@lambry lambry deleted the feature/search-banner-feedback branch January 19, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lambry @jeffdowdle