Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-527] add page detail to search, sitemap and print all pages #1402

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 9, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-527

What I did

  • Add page detail to search, sitemap and print all pages so they come through in the analytics events
  • Also update the sitemap page title to be consistent with the rest and avoid the double site name
Screenshot 2024-12-09 at 10 44 17 am

Events

Screenshot 2024-12-09 at 10 26 16 am Screenshot 2024-12-09 at 10 27 01 am Screenshot 2024-12-09 at 10 27 49 am

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Dec 9, 2024
@lambry lambry added this to the 2.23.0 milestone Dec 9, 2024
@dylankelly dylankelly merged commit 1cbf987 into release/2.23.0 Dec 9, 2024
6 of 7 checks passed
@dylankelly dylankelly deleted the feature/static-page-titles branch December 9, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants