Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-180] add search support to dropdowns #1399

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 6, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-180

What I did

  • Adds search support to dropdowns

Test webform: https://app.pr-149.reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/test-wf
Test search listing: https://app.pr-149.reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/test-sl

Full dropdown component test suite

dropdown.cy.mov

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 81d8bb7
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6757a22b98a97500086bfc3a

@lambry lambry added this to the 2.23.0 milestone Dec 10, 2024
@lambry lambry changed the base branch from develop to release/2.23.0 December 10, 2024 02:14
Copy link

cypress bot commented Dec 10, 2024

ripple-framework    Run #2468

Run Properties:  status check passed Passed #2468  •  git commit 0dc217847b: feat(@dpc-sdp/ripple-ui-forms): display items in the order they're selected
Project ripple-framework
Branch Review feature/dropdown-combobox
Run status status check passed Passed #2468
Run duration 10m 06s
Commit git commit 0dc217847b: feat(@dpc-sdp/ripple-ui-forms): display items in the order they're selected
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@lambry lambry marked this pull request as ready for review December 10, 2024 02:45
Copy link
Member

@waitingallday waitingallday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all works 😄 I'm sure this has been done to death, but the only issue I have is with the ordering of selected elements - I would prefer it to list them in order of selection instead of sticking to list order. I'm sure there are reasons though.

@lambry
Copy link
Contributor Author

lambry commented Dec 16, 2024

It all works 😄 I'm sure this has been done to death, but the only issue I have is with the ordering of selected elements - I would prefer it to list them in order of selection instead of sticking to list order. I'm sure there are reasons though.

@waitingallday Yeah that's just how the drop-downs currently work, but I think appearing in the order you selected would be better as well. I'll suggest it on the ticket.

Screenshot 2024-12-16 at 11 24 18 am

@dylankelly
Copy link
Contributor

Another suggestion I'd make is to clear the search text input when you make a selection. At the moment you need to delete your input to make another search

9dvzuz.mp4

@jeffdowdle
Copy link
Contributor

👏 👏 👏

@lambry
Copy link
Contributor Author

lambry commented Dec 16, 2024

Another suggestion I'd make is to clear the search text input when you make a selection. At the moment you need to delete your input to make another search
9dvzuz.mp4

Hey @dylankelly, I can see both ways here.
For example, say you had a dropdown with several items relating to education, you type 'edu' then want to select the three related results, in this instance clearing the input would mean you would have to redo your search two more times, It's a trade off either way though.

Also @waitingallday options now display in the order which they were selected. 👍

Cheers

@dylankelly dylankelly merged commit 0fa76b8 into release/2.23.0 Dec 16, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feature/dropdown-combobox branch December 16, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants