-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-180] add search support to dropdowns #1399
Conversation
✅ Deploy Preview for ripple-docs canceled.
|
ripple-framework Run #2468
Run Properties:
|
Project |
ripple-framework
|
Branch Review |
feature/dropdown-combobox
|
Run status |
Passed #2468
|
Run duration | 10m 06s |
Commit |
0dc217847b: feat(@dpc-sdp/ripple-ui-forms): display items in the order they're selected
|
Committer | David Featherston |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
214
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all works 😄 I'm sure this has been done to death, but the only issue I have is with the ordering of selected elements - I would prefer it to list them in order of selection instead of sticking to list order. I'm sure there are reasons though.
@waitingallday Yeah that's just how the drop-downs currently work, but I think appearing in the order you selected would be better as well. I'll suggest it on the ticket. |
Another suggestion I'd make is to clear the search text input when you make a selection. At the moment you need to delete your input to make another search 9dvzuz.mp4 |
👏 👏 👏 |
Hey @dylankelly, I can see both ways here. Also @waitingallday options now display in the order which they were selected. 👍 Cheers |
Issue: https://digital-vic.atlassian.net/browse/SD-180
What I did
Test webform: https://app.pr-149.reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/test-wf
Test search listing: https://app.pr-149.reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/test-sl
Full dropdown component test suite
dropdown.cy.mov
Checklist
For all PR's
For new UI components only
emitRplEvent