Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-508] ensure popup area doesn't extend beyond visible popup #1392

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 28, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-508

What I did

  • Ensure popup area doesn't extend beyond popup, i.e. the margin at the top of the popup was blocking interactions
  • Adjust active pin (was a pixel off)

Click above (Current)

click-above-current

Click above (Updated)

click-above-updated

Hover above (Current)

hover-above-current

Hover above (Updated)

hover-above-updated

Move active pin 1px

marker-1px-off

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit c44d7c2
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6748f7edeb085c000821ac07

@lambry lambry changed the base branch from develop to release/2.22.0 December 2, 2024 23:00
@lambry lambry added this to the 2.22.0 milestone Dec 2, 2024
@lambry lambry merged commit 583af52 into release/2.22.0 Dec 3, 2024
11 checks passed
@lambry lambry deleted the feature/popover-margins branch December 3, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants