Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-463] Add linkset processor for site menus #1390

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-463

What I did

  • Added processor to hydrate API response from drupal linkset endpoint
  • Added unit test
  • Refactored original menu_items processor

How to test

  • Unit tests
  • nuxt-app

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.22.0 milestone Nov 28, 2024
@waitingallday waitingallday self-assigned this Nov 28, 2024
Copy link

cypress bot commented Nov 28, 2024

ripple-framework    Run #2427

Run Properties:  status check passed Passed #2427  •  git commit 170ff15a48: refactor(@dpc-sdp/ripple-tide-api): ♻️ use existing util
Project ripple-framework
Branch Review feat/linkset-menu
Run status status check passed Passed #2427
Run duration 09m 26s
Commit git commit 170ff15a48: refactor(@dpc-sdp/ripple-tide-api): ♻️ use existing util
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@waitingallday
Copy link
Member Author

Oops didn't leave any instructions to test this:

  1. Backend with linkset enabled https://nginx-php.pr-1740.content-vic.sdp4.sdp.vic.gov.au
  2. Endpoint is (e.g. vic main) https://nginx-php.pr-1740.content-vic.sdp4.sdp.vic.gov.au/system/menu/site-main-menu-vicgovau/linkset
  3. Set in nuxt.config.ts
  runtimeConfig: {
    public: {
      tide: {
        menuEndpoint: 'linkset'
        ...

@waitingallday waitingallday requested a review from lambry December 5, 2024 06:05
@dylankelly dylankelly merged commit 7546459 into release/2.22.0 Dec 8, 2024
7 checks passed
@dylankelly dylankelly deleted the feat/linkset-menu branch December 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants