Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-403] Map search banner component build #1386

Closed
wants to merge 1 commit into from

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-403

What I did

  • Component build in ripple-tide-landing-page so that it can be inserted as a header comp TideLandingPageMapSearchBanner
  • I mocked in some props, these might need to change
{
    "uuid": "27b0781b-2533-40ba-a9da-28fefc41d83e",
    "component": "TideLandingPageMapSearchBanner",
    "id": "3434418",
    "props": {
        "title": "Search heading",
        "intro": "Introduction text",
        "searchPlaceholder": "Search for a centre",
        "image": "/placeholders/mapbg.png"
    }
}
  • The component itself has a slot for rendering the search input

How to test

  • Cypress test to demonstrate desktop and mobile builds

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.21.0 milestone Nov 20, 2024
@waitingallday waitingallday self-assigned this Nov 20, 2024
Copy link

cypress bot commented Nov 20, 2024

ripple-framework    Run #2397

Run Properties:  status check passed Passed #2397  •  git commit 187bf3ace9: feat(@dpc-sdp/ripple-tide-landing-page): :sparkles: new component build
Project ripple-framework
Branch Review feat/sd-403-search-map-header
Run status status check passed Passed #2397
Run duration 09m 31s
Commit git commit 187bf3ace9: feat(@dpc-sdp/ripple-tide-landing-page): :sparkles: new component build
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 212
View all changes introduced in this branch ↗︎

@jeffdowdle
Copy link
Contributor

Closing in favour of #1388

@jeffdowdle jeffdowdle closed this Nov 25, 2024
@waitingallday waitingallday removed this from the 2.21.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants