Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-504] routeChange topic and tags #1385

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[SD-504] routeChange topic and tags #1385

merged 1 commit into from
Nov 19, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 18, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-504

What I did

  • add topic and tags to routeChange event

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.21.0 milestone Nov 18, 2024
@lambry lambry self-assigned this Nov 18, 2024
@cypress Cypress
Copy link

cypress bot commented Nov 18, 2024

ripple-framework    Run #2393

Run Properties:  status check passed Passed #2393  •  git commit 3c8f9aebb3: feat(@dpc-sdp/nuxt-ripple): add topic and tags to base mapping and routeChange
Project ripple-framework
Branch Review feature/route-topics-and-tags
Run status status check passed Passed #2393
Run duration 09m 27s
Commit git commit 3c8f9aebb3: feat(@dpc-sdp/nuxt-ripple): add topic and tags to base mapping and routeChange
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎

@lambry lambry merged commit bb07d60 into release/2.21.0 Nov 19, 2024
7 checks passed
@lambry lambry deleted the feature/route-topics-and-tags branch November 19, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lambry @waitingallday