Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-481] map markers not using themed colour on sites #1374

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 12, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-481

What I did

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.21.0 milestone Nov 12, 2024
@lambry lambry self-assigned this Nov 12, 2024
Copy link

cypress bot commented Nov 12, 2024

ripple-framework    Run #2361

Run Properties:  status check passed Passed #2361  •  git commit 387c291f48: fix(@dpc-sdp/ripple-ui-maps): map markers not using themed colour on sites
Project ripple-framework
Branch Review bugfix/default-map-pin-colours
Run status status check passed Passed #2361
Run duration 09m 12s
Commit git commit 387c291f48: fix(@dpc-sdp/ripple-ui-maps): map markers not using themed colour on sites
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

@lambry lambry merged commit a3ad6c9 into release/2.21.0 Nov 14, 2024
6 checks passed
@lambry lambry deleted the bugfix/default-map-pin-colours branch November 14, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants