Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-409] - Made padding for zooming into bbox configurable per map #1372

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-409

What I did

  • Added bboxZoomPadding to address lookup component so that it can be customised per map
  • Kept the default value as is to keep backwards compat

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@jeffdowdle jeffdowdle added this to the 2.21.0 milestone Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 17cc348
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6732b17cd967750008336b68

Copy link

cypress bot commented Nov 12, 2024

ripple-framework    Run #2357

Run Properties:  status check passed Passed #2357  •  git commit 17cc348b97: feat(@dpc-sdp/ripple-tide-search): made padding for zooming into bbox configurab...
Project ripple-framework
Branch Review feature/SD-409-map-padding
Run status status check passed Passed #2357
Run duration 09m 27s
Commit git commit 17cc348b97: feat(@dpc-sdp/ripple-tide-search): made padding for zooming into bbox configurab...
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 209
View all changes introduced in this branch ↗︎

@jeffdowdle jeffdowdle changed the base branch from develop to release/2.21.0 November 12, 2024 22:32
@jeffdowdle jeffdowdle merged commit fd69d93 into release/2.21.0 Nov 12, 2024
10 checks passed
@jeffdowdle jeffdowdle deleted the feature/SD-409-map-padding branch November 12, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants