Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-442] move contentCollectionSearchConnector feature flag #1362

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Oct 29, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-442

What I did

  • Moves the contentCollectionSearchConnector feature flag into ripple-tide-landing-page the one place it's used so the default doesn't need to come from individual projects (can still be overridden in individual projects)

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for ripple-docs ready!

Name Link
🔨 Latest commit 9447a2c
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/67204bd5558e590008d8d0d6
😎 Deploy Preview https://deploy-preview-1362--ripple-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambry lambry changed the base branch from develop to release/2.20.0 October 29, 2024 02:44
@lambry lambry added this to the 2.20.0 milestone Oct 29, 2024
Copy link

cypress bot commented Oct 29, 2024

ripple-framework    Run #2335

Run Properties:  status check passed Passed #2335  •  git commit 80eaa676b0: Merge branch 'release/2.20.0' into bugfix/content-collection-fix
Project ripple-framework
Branch Review bugfix/content-collection-fix
Run status status check passed Passed #2335
Run duration 17m 21s
Commit git commit 80eaa676b0: Merge branch 'release/2.20.0' into bugfix/content-collection-fix
Committer dylankelly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

@lambry lambry merged commit c0ca502 into release/2.20.0 Oct 29, 2024
13 of 14 checks passed
@lambry lambry deleted the bugfix/content-collection-fix branch October 29, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants