[SD-430] 🐛 handle missing menus better #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
jeffdowdle
reviewed
Oct 23, 2024
| @@ -14,7 +14,12 @@ export const map = async (src, tidePageApi: TidePageApi) => { | |||
|
|
|||
| // Finally, this site data will contain a reference to the menu we need to fetch | |||
| const menuData = siteData.field_site_main_menu | |||
|
|
|||
| if (menuData.id === 'missing') { | |||
There was a problem hiding this comment.
Do we need to menuData?.id incase menuData is undefined here?
ripple-framework
|
||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
feaeture/fix-missing-menu
|
| Run status |
|
| Run duration | 09m 05s |
| Commit |
|
| Committer | Dylan Kelly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
207
|
| View all changes introduced in this branch ↗︎ | |
ae84dc7 to
1640612
Compare
jeffdowdle
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent