Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-265] add date range field #1348

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Oct 11, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-265

What I did

  • Add a core date range field and search listing support

This can search against a single field

"filter": {
  "type": "range",
  "value": "published_date"
},

Or two fields, i.e. a date range like events

"filter": {
  "type": "range",
  "value": {
    "start": "field_event_date_start_value",
    "end": "field_event_date_end_value"
  }
}
Screenshot 2024-10-11 at 10 59 09 am

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Oct 11, 2024
Copy link

cypress bot commented Oct 13, 2024

ripple-framework    Run #2290

Run Properties:  status check passed Passed #2290  •  git commit 3cd25fc1bf: chore(@dpc-sdp/ripple-ui-core): update dataLayer value format
Project ripple-framework
Run status status check passed Passed #2290
Run duration 09m 31s
Commit git commit 3cd25fc1bf: chore(@dpc-sdp/ripple-ui-core): update dataLayer value format
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 206

@lambry lambry added this to the 2.18.0 milestone Oct 14, 2024
@dylankelly dylankelly merged commit 5906e32 into release/2.18.0 Oct 14, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feature/date-range-field branch October 14, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants