Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-217] Move examples to separate layers #1345

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[SD-217] Move examples to separate layers #1345

merged 1 commit into from
Oct 7, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-217

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday self-assigned this Oct 3, 2024
@waitingallday waitingallday added this to the 2.18.0 milestone Oct 3, 2024
@dylankelly dylankelly merged commit 898d5dc into release/2.18.0 Oct 7, 2024
6 checks passed
@dylankelly dylankelly deleted the feat/sd-217-example-layers branch October 7, 2024 23:06
@lambry lambry mentioned this pull request Nov 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@lambry lambry Awaiting requested review from lambry

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@waitingallday @dylankelly