Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-353] add full stop to the end of sentence #1337

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[SD-353] add full stop to the end of sentence #1337

merged 1 commit into from
Sep 26, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 26, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-353

What I did

  • add full stop to the end of sentence

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry added this to the 2.17.0 milestone Sep 26, 2024
@lambry lambry self-assigned this Sep 26, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 26, 2024

ripple-framework    Run #2258

Run Properties:  status check passed Passed #2258  •  git commit da648273df: fix(@dpc-sdp/ripple-tide-search): add full stop to the end of sentence
Project ripple-framework
Branch Review bugfix/location-message
Run status status check passed Passed #2258
Run duration 08m 58s
Commit git commit da648273df: fix(@dpc-sdp/ripple-tide-search): add full stop to the end of sentence
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 201
View all changes introduced in this branch ↗︎

@dylankelly dylankelly merged commit 805e569 into release/2.17.0 Sep 26, 2024
6 checks passed
@dylankelly dylankelly deleted the bugfix/location-message branch September 26, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lambry @dylankelly