Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-291] add aria label to vertical nav toggles #1325

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 16, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-291

What I did

  • Add aria label to vertical nav toggles
  • Remove un-needed tabindex

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Sep 16, 2024
Copy link

cypress bot commented Sep 16, 2024

ripple-framework    Run #2218

Run Properties:  status check passed Passed #2218  •  git commit ca11280f80: fix(@dpc-sdp/ripple-ui-core): remove un-needed tabindex from vertical nav
Project ripple-framework
Branch Review feature/vertical-nav-toggles
Run status status check passed Passed #2218
Run duration 13m 05s
Commit git commit ca11280f80: fix(@dpc-sdp/ripple-ui-core): remove un-needed tabindex from vertical nav
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 196
View all changes introduced in this branch ↗︎

@lambry lambry added this to the 2.17.0 milestone Sep 16, 2024
@lambry lambry merged commit eb70d22 into release/2.17.0 Sep 17, 2024
13 of 14 checks passed
@lambry lambry deleted the feature/vertical-nav-toggles branch September 17, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants