Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-278] RTL accordion heading #1310

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-278

What I did

  • Right align title text in RTL accordion headings
  • Also patched another parse5 sourcemap to suppress dev mode runtime warning

Current state
Screenshot 2024-09-02 at 5 20 30 PM

Corrected
Screenshot 2024-09-02 at 5 20 39 PM

How to test

  • Cypress (updated RTL fixture with line breaking heading)

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday added this to the 2.16.0 milestone Sep 2, 2024
@waitingallday waitingallday self-assigned this Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4f76696
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66d56a50e9e8fa0008bda5fd

@waitingallday
Copy link
Member Author

🚨 will need to rebase this to release/2.16.0 when #1307 is merged into develop, and the new branch is up

Copy link

cypress bot commented Sep 2, 2024

ripple-framework    Run #2180

Run Properties:  status check passed Passed #2180  •  git commit 4f766964cd: fix(@dpc-sdp/ripple-ui-core): :bug: right align rtl accordion heading
Project ripple-framework
Branch Review task/sd-278-accordion-title-rtl
Run status status check passed Passed #2180
Run duration 09m 56s
Commit git commit 4f766964cd: fix(@dpc-sdp/ripple-ui-core): :bug: right align rtl accordion heading
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 188
View all changes introduced in this branch ↗︎

@waitingallday waitingallday changed the base branch from develop to release/2.16.0 September 2, 2024 23:54
@waitingallday waitingallday merged commit cd987b4 into release/2.16.0 Sep 2, 2024
17 of 18 checks passed
@waitingallday waitingallday deleted the task/sd-278-accordion-title-rtl branch September 2, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants