Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-144] fix map fullscreen button #1303

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 23, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-144

What I did

  • The close button (i.e. cross icon) wasn't displaying when the map goes full screen
  • Also requestFullscreen is, to quote MDN "Only available on iPad, not on iPhone.", so now we don't display the full screen button if it won't work i.e. on iPhones.

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Aug 23, 2024
@lambry lambry added this to the 2.15.0 milestone Aug 23, 2024
@dylankelly dylankelly merged commit 194db31 into release/2.15.0 Aug 26, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the bugfix/map-fullscreen-btn branch August 26, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants