Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-191] allow setting a defaultExtent value #1297

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[SD-191] allow setting a defaultExtent value #1297

merged 2 commits into from
Aug 20, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 20, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-191

What I did

  • Allow for setting a default extent to take place of the Victoria default

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Aug 20, 2024
@dylankelly dylankelly merged commit bbd20c6 into release/2.15.0 Aug 20, 2024
4 checks passed
@dylankelly dylankelly deleted the feature/default-extent branch August 20, 2024 00:14
@waitingallday waitingallday added this to the 2.15.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @waitingallday