Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRM-1505] add default timeZone for formatDate #1293

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 14, 2024

Issue: https://digital-vic.atlassian.net/browse/SRM-1505

What I did

  • Add default timeZone for formatDate so it matches the other date formatter and avoids rare hydration missmatch warnings

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Aug 14, 2024
@waitingallday waitingallday added this to the 2.15.0 milestone Aug 15, 2024
@waitingallday waitingallday changed the base branch from release/2.14.0 to release/2.15.0 August 15, 2024 06:35
@lambry lambry changed the title fix(@dpc-sdp/ripple-ui-core): add default timeZone for formatDate [SRM-1505] add default timeZone for formatDate Aug 15, 2024
@dylankelly dylankelly merged commit 9e18f07 into release/2.15.0 Aug 16, 2024
22 of 23 checks passed
@dylankelly dylankelly deleted the bugfix/format-date branch August 16, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants